Changing selectExprNeedsAlias to consider string literal quotes
#2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
force-pushed
the
fulghum/doltgres-fix
branch
from
32a658c
to
5f71687
Compare
fulghum
force-pushed
the
fulghum/doltgres-fix
branch
from
89a60a1
to
64ebafe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fixing a string literal quoting issue in Doltgres (dolthub/doltgresql#868), table functions stopped working, because the
selectExprNeedsAliasstarted returningtrueto indicate that an alias was needed (even though it wasn't) and thebuildTableFuncfunction would fail.This started happening because the quoted string literals no longer matched
InputExpression, sinceInputExpressionalways trims off quotes when it is assigned. Another solution could be to expose thetrimQuotesfunction from Vitess and use it to trimexpr.String()before matching againstInputExpression.